REQUEST: Repository maintenance on opentelemetry-collector-contrib

[dmitryax]

Affected Repository

• http:https://github.com/open-telemetry/opentelemetry-collector-contrib

Requested changes

Give 'Admin' permissions to @dmitryax

Or, if possible, grant @open-telemetry/collector-contrib-maintainer permissions to change Branch protection rules permanently

Purpose

Similar to #1636.

We are migrating the Go version support from 1.19-1.20 to 1.20-1.21. Therefore, we need to update the required CI tests for the protected main branch to use the new versions.

Expected Duration

1 week. We'll comment again on this issue once we are done so the permissions can be reverted.

Repository Maintainers

• @open-telemetry/collector-contrib-maintainer

[trask]

if possible, grant https://github.com/orgs/open-telemetry/teams/collector-contrib-maintainer permissions to change Branch protection rules permanently

you can request permanent Admin permission if you want, check out

community/docs/how-to-configure-new-repository.md

Lines 43 to 47 in 1fe51b7

	If requested, `foo-maintainers` will be granted `Admin` permissions, and in return
	they must document any changes they make to the repository settings in a file named
	`.github/repository-settings.md` in their repository (other than temporarily
	disabling "Do not allow bypassing the above settings", see branch protection rules
	below).

[dmitryax]

you can request permanent Admin permission if you want, check out

I'm good with any approach. We can submit requests here every time or maintain .github/repository-settings.md. @open-telemetry/collector-contrib-maintainer what would you prefer?

[trask]

another option that works well if you are only needing this for updating the required status checks is to have a single "required status check" job, and make it a dependency of your other jobs, e.g. https://github.com/open-telemetry/opentelemetry-java-examples/blob/9a42295cd56ed1706673822d63288fbc5e35064a/.github/workflows/build.yml#L53

[dmitryax]

another option that works well if you are only needing this for updating the required status checks is to have a single "required status check" job, and make it a dependency of your other jobs, e.g. https://github.com/open-telemetry/opentelemetry-java-examples/blob/9a42295cd56ed1706673822d63288fbc5e35064a/.github/workflows/build.yml#L53

I would like to avoid going this route. It's nice to see which required jobs failed explicitly instead of jumping through an additional job.

[dmitryax]

@trask, I think we can apply your suggestion just for unittest job and have one required check for all the go versions to avoid going through this exercise every 6 months. cc @open-telemetry/collector-contrib-maintainer

I submitted open-telemetry/opentelemetry-collector-contrib#25151 for this issue and open-telemetry/opentelemetry-collector#8218 for #1636

[dmitryax]

@open-telemetry/governance-committee, the PRs ^ are approved. Instead of providing the Admin permissions, you can help us with switching the required jobs from unittest (1.19) and unittest (1.20) to unittest in:

• http:https://github.com/open-telemetry/opentelemetry-collector-contrib to close this issue
• http:https://github.com/open-telemetry/opentelemetry-collector to close REQUEST: Repository maintenance on opentelemetry-collector #1636

Thank you!

[trask]

@trask, the PRs ^ are approved. Can you please help us with switching the required jobs from unittest (1.19) and unittest (1.20) to unittest

paging someone from @open-telemetry/technical-committee who have the permissions to do this ☎️

[arminru]

@dmitryax I changed the settings in https://github.com/open-telemetry/opentelemetry-collector as requested. For -contrib there is no such job name but rather some dozens of jobs based on a matrix. Do you intend to keep it there like that or will open-telemetry/opentelemetry-collector#8218 also be ported to -contrib?

[arminru]

Found your PR open-telemetry/opentelemetry-collector-contrib#25151 in the meantime.

Unfortunately the 30-ish recommendations the Github UI gives when filtering for unittest did not include the plain unittest but all of the individual matrix branch results instead...
I was able to get it to set it to just unittest by replacing the branch protection rule via the Github API now and it looks like it worked: