Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalized OHEM #54

Merged
merged 5 commits into from
Aug 9, 2020
Merged

Generalized OHEM #54

merged 5 commits into from
Aug 9, 2020

Conversation

xvjiarui
Copy link
Collaborator

@xvjiarui xvjiarui commented Aug 6, 2020

This PR make OHEM more generalized.
It supports 2 modes:

  1. Select hard examples by threshold on prediction probability.
  2. Select hard examples by loss.

It also fixed #52 .

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #54 into master will increase coverage by 0.02%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   81.50%   81.53%   +0.02%     
==========================================
  Files          71       71              
  Lines        3158     3162       +4     
  Branches      493      494       +1     
==========================================
+ Hits         2574     2578       +4     
  Misses        496      496              
  Partials       88       88              
Flag Coverage Δ
#unittests 81.53% <85.71%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/models/decode_heads/decode_head.py 91.66% <0.00%> (ø)
mmseg/core/seg/sampler/ohem_pixel_sampler.py 94.59% <90.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00f56eb...d7729db. Read the comment docs.

@xvjiarui xvjiarui requested a review from hellock August 8, 2020 15:44
@hellock hellock merged commit 5e264c6 into open-mmlab:master Aug 9, 2020
johnzja pushed a commit to johnzja/mmsegmentation that referenced this pull request Aug 19, 2020
* Generalized OHEM

* remove config

* update docstring

* fixed sort prob

* fixed valid_mask
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
* Generalized OHEM

* remove config

* update docstring

* fixed sort prob

* fixed valid_mask
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
sibozhang pushed a commit to sibozhang/mmsegmentation that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About mmseg OHEMSampler Implementation
2 participants