From 83bff18fcecb5951634db2b7a45045d9d131f655 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miguel=20M=C3=A9ndez?= Date: Mon, 4 Dec 2023 07:23:29 +0100 Subject: [PATCH] [Bugfix] Allow custom visualizer (#3455) Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers. ## Motivation Current Visualization Hook can only get instances of `SegLocalVisualizer`. This makes impossible to use any other custom implementation. ## Modification This PR just allows to instantiate a different visualizer (following mmdetection implementation): https://github.com/open-mmlab/mmdetection/blob/main/mmdet/engine/hooks/visualization_hook.py#L58 --- mmseg/engine/hooks/visualization_hook.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/mmseg/engine/hooks/visualization_hook.py b/mmseg/engine/hooks/visualization_hook.py index 1e7c97afe8..ea238c6969 100644 --- a/mmseg/engine/hooks/visualization_hook.py +++ b/mmseg/engine/hooks/visualization_hook.py @@ -7,10 +7,10 @@ import mmengine.fileio as fileio from mmengine.hooks import Hook from mmengine.runner import Runner +from mmengine.visualization import Visualizer from mmseg.registry import HOOKS from mmseg.structures import SegDataSample -from mmseg.visualization import SegLocalVisualizer @HOOKS.register_module() @@ -42,8 +42,7 @@ def __init__(self, show: bool = False, wait_time: float = 0., backend_args: Optional[dict] = None): - self._visualizer: SegLocalVisualizer = \ - SegLocalVisualizer.get_current_instance() + self._visualizer: Visualizer = Visualizer.get_current_instance() self.interval = interval self.show = show if self.show: