Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Replace self.file_client.get_local_path(self.ann_file) with get_local_path(self.ann_file) #2335

Open
HAOCHENYE opened this issue Mar 8, 2023 · 1 comment

Comments

@HAOCHENYE
Copy link

HAOCHENYE commented Mar 8, 2023

What's the feature?

MMEngine has refactor the fileio since version 0.2.0, and the backend can be inferred according to the format of path automatically in series of interfaces, such as get_local_path. Thanks to this improvement, we do not need to set the default argument like file_client_args=dict(type='disk')

https://github.com/search?q=repo%3Aopen-mmlab%2Fmmdetection3d+file_client_args%3Ddict&type=code

and then write code like that:

https://github.com/search?q=repo%3Aopen-mmlab%2Fmmdetection3d%20get_local_path&type=code

If we directly use the new get_local_path, users can simply set data_root as an s3 path like s3:https://xxx/xxx without configuring file_client_args.

Any other context?

No response

@Xiangxu-0103
Copy link
Collaborator

Has been refactored in #2319.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants