Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert login design for mobile something like this #7062

Closed
lmmrssa opened this issue Mar 18, 2022 · 9 comments · Fixed by #7073
Closed

Convert login design for mobile something like this #7062

lmmrssa opened this issue Mar 18, 2022 · 9 comments · Fixed by #7073
Assignees

Comments

@lmmrssa
Copy link
Member

lmmrssa commented Mar 18, 2022

image

image

@rheam97 rheam97 self-assigned this Mar 19, 2022
@rheam97
Copy link
Contributor

rheam97 commented Mar 19, 2022

Hey @lmmrssa what screen size is this? in my Firefox, mobile has a max width of 375 px. Also, should I do this instead of the second part of the last issue?

@rheam97
Copy link
Contributor

rheam97 commented Mar 21, 2022

Hi @lmmrssa, so I tried to keep the display grid, but even when I set it to one column, it doesn't look right. so for the mobile for now I've changed it to display flex with a flex-direction of column and it looks closer to this.
Screen Shot 2022-03-21 at 7 07 32 AM

vs. flex

Screen Shot 2022-03-21 at 7 07 59 AM

@lmmrssa
Copy link
Member Author

lmmrssa commented Mar 21, 2022

@rheam97 it is not about fix screen size we mostly need to look at which screensize current design breaks and add style based on that. We can take tablet size and mobile size and also look at orientation. i.e. width and height ratio.

rheam97 added a commit that referenced this issue Mar 23, 2022
… see if it works without container padding (fixes #7062)
@rheam97
Copy link
Contributor

rheam97 commented Mar 23, 2022

hi @lmmrssa I was able to make the layout you wanted but im still having issues with the build even though the branch is named '7062-mobilelogin'. Here is what it looks like:
Screen Shot 2022-03-23 at 5 31 34 PM

@rheam97
Copy link
Contributor

rheam97 commented Mar 23, 2022

Ill fix the logo actually during the hacking meeting

@rheam97
Copy link
Contributor

rheam97 commented Mar 25, 2022

@lmmrssa Im having an issue making it landscape because its not taking the properties that I put in the landscape media query. I don't want to use the !important property because I noticed and saw that it messes everything else up before it.
Screen Shot 2022-03-25 at 3 38 14 PM

@rheam97
Copy link
Contributor

rheam97 commented Mar 25, 2022

@lmmrssa I removed the important properties because I think it won't be as easily maintainable with them. it sort of messed up the progress I've made

@rheam97
Copy link
Contributor

rheam97 commented Mar 25, 2022

fixed it!

@rheam97
Copy link
Contributor

rheam97 commented Mar 28, 2022

@lmmrssa added a div to wrap the text in the left tile for the mobile portrait, but I think the inline looks better than the row. What do you think?
Inline:
Screen Shot 2022-03-28 at 9 43 26 AM

Flex-row:
Screen Shot 2022-03-28 at 9 43 14 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants