-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert login design for mobile something like this #7062
Comments
Hey @lmmrssa what screen size is this? in my Firefox, mobile has a max width of 375 px. Also, should I do this instead of the second part of the last issue? |
Hi @lmmrssa, so I tried to keep the display grid, but even when I set it to one column, it doesn't look right. so for the mobile for now I've changed it to display flex with a flex-direction of column and it looks closer to this. vs. flex |
@rheam97 it is not about fix screen size we mostly need to look at which screensize current design breaks and add style based on that. We can take tablet size and mobile size and also look at orientation. i.e. width and height ratio. |
… see if it works without container padding (fixes #7062)
hi @lmmrssa I was able to make the layout you wanted but im still having issues with the build even though the branch is named '7062-mobilelogin'. Here is what it looks like: |
Ill fix the logo actually during the hacking meeting |
@lmmrssa Im having an issue making it landscape because its not taking the properties that I put in the landscape media query. I don't want to use the !important property because I noticed and saw that it messes everything else up before it. |
@lmmrssa I removed the important properties because I think it won't be as easily maintainable with them. it sort of messed up the progress I've made |
fixed it! |
@lmmrssa added a div to wrap the text in the left tile for the mobile portrait, but I think the inline looks better than the row. What do you think? |
… see if it works without container padding (fixes #7062)
Co-authored-by: mutugiii <[email protected]>
The text was updated successfully, but these errors were encountered: