Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

responsive login screen (fixes #7062 and #7067) #7073

Merged
merged 19 commits into from
Jun 9, 2022
Merged

Conversation

rheam97
Copy link
Contributor

@rheam97 rheam97 commented Mar 28, 2022

Fixes #7062 #7067

Description

made mobile portrait, works for small screens
made padding 0 for portrait and landscape
also added landscape query, works for small screens as well
added div to wrap text in login left tile container so that display is row in portrait, does not affect mobile landscape or web layout

Result

Screen Shot 2022-03-28 at 9 43 14 AM

Screen Shot 2022-03-25 at 1 37 53 PM

@rheam97 rheam97 requested a review from lmmrssa March 28, 2022 15:11
@Mutugiii
Copy link
Member

Mutugiii commented May 4, 2022

@lmmrssa In some cases it seems that the form still jumps out of the login-tile

ole_login_overlap

In this case, when the height is at 650 and the width is in the range 400(value when the media query is triggered) to 550, some elements of the form are outside the white login-tile. The width range when form components are outside the screen changes based on the height of the screen

@Mutugiii
Copy link
Member

Mutugiii commented May 4, 2022

Planet.Learning.-.4.May.2022.mp4

In the mobile layout, for smaller screens, it seems that in this case around 270px width, a scrollbar appears

@Mutugiii
Copy link
Member

Mutugiii commented May 9, 2022

@lmmrssa I've pushed some changes to incorporate the additions we discussed

@lmmrssa
Copy link
Member

lmmrssa commented May 9, 2022

@Mutugiii for mobile sizes it looks good. For tablet size make it looks similar to desktop but remove padding around. i.e. blue space around form

@lmmrssa
Copy link
Member

lmmrssa commented May 11, 2022

this is not as expected when you keep changing with of screen it jump between one with padding and without padding and again with padding. there is should be on break point and after that it should have padding.

@Mutugiii
Copy link
Member

@lmmrssa I've updated the PR incorporating a line break for the On android? try Planet line that was implemented in the #7065

@lmmrssa lmmrssa changed the title update to login.component.html and login.scss (fixes #7062 and #7067) responsive login screen (fixes #7062 and #7067) Jun 9, 2022
@lmmrssa lmmrssa merged commit eff3e74 into master Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert login design for mobile something like this
3 participants