Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collections Dialog: Dedicated close button #6882

Open
Haoran-Hu opened this issue Jul 21, 2020 · 1 comment · May be fixed by #7001
Open

Collections Dialog: Dedicated close button #6882

Haoran-Hu opened this issue Jul 21, 2020 · 1 comment · May be fixed by #7001
Labels
low priority Newbie Friendly

Comments

@Haoran-Hu
Copy link
Member

There is no dedicated cancel button for Collections dialog. Adding a cancel button to exit the dialog instead of click on the page outside of the dialog may be a better practice.

Screenshot

Screen Shot 2020-07-20 at 9 20 58 PM
@paulbert paulbert changed the title Collections Dialog: Dedicated cancel button Collections Dialog: Dedicated close button Jul 21, 2020
@paulbert
Copy link
Member

Changing this to Close since it won't cancel an action.

@dyeh123 dyeh123 linked a pull request Aug 19, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low priority Newbie Friendly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CollectionsDialog: add close button (fixes #6882) dyeh123/planet
2 participants
@paulbert @Haoran-Hu