Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExamsQuestion: Clean up validation messages #3784

Open
paulbert opened this issue May 9, 2019 · 3 comments · May be fixed by #6752
Open

ExamsQuestion: Clean up validation messages #3784

paulbert opened this issue May 9, 2019 · 3 comments · May be fixed by #6752
Assignees
@jsschf

Comments

@paulbert
Copy link
Member

paulbert commented May 9, 2019

Validation messages are not showing up in the best way in the exam question forms.

  • When adding a second question after finishing the first, the validation messages show up. This is because it's the same form with the values reset to blank, but they are still considered "touched" for the form validation so errors show up.
  • The "You must add a choice..." error should never show up for text question types.
  • The main "Some required fields are missing" message should only show up after trying to submit and once the errors are fixed it should go away.
@paulbert
Copy link
Member Author

paulbert commented May 9, 2019

In addition to the above, there is a div with an error message for not selecting a correct choice that no longer shows up. Note this should also never show up for text question types.

@simily00 simily00 self-assigned this May 16, 2019
@paulbert
Copy link
Member Author

paulbert commented Jul 2, 2020

Looking at this issue again, there are now only two of the four tasks left:

  1. The main "Some required fields are missing" message should go away after all errors are fixed.
  2. The error message "You must add a choice..." does not show up. This should only show up for multiple choice question types, never text question types.

I think the first one will be much more difficult than the second, so we might need to split this into two PRs.

@jsschf
Copy link
Member

jsschf commented Jul 2, 2020

For me:

  • The choice error messages are already present in ExamsQuestionComponent, I just need to figure out why they aren't triggering.
  • The "Some required fields are messing" should automatically disappear when the form becomes valid.

jsschf added a commit that referenced this issue Jul 6, 2020
@jsschf
Initial commit (fixes #3784)
bc7a050
@jsschf jsschf linked a pull request Jul 6, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsschf jsschf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Courses: Fix Exam error messages open-learning-exchange/planet
3 participants
@paulbert @simily00 @jsschf