-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library: Change collections #6421
Comments
cancel is supposed to close the dialog, we put reset to clear selection there usually for case when there are lot of collection. |
May be addding additional cancel can be ok to keep consistent with closing popup. So will still keep it as question for now |
The reset button is useful since it resets the selection to the initial state when you opened the dialog. Maybe cancel would be simpler. Maybe both buttons, but I think having both "Reset" and "Cancel" could be confusing. I'm going to mark this On Hold since this is not a priority feature. Maybe we will revisit at a later date. |
Should the dialog have the "cancel" button instead of "reset" button?
When you click "ok"the collection gets reset.
The text was updated successfully, but these errors were encountered: