Rating bar gets hidden

[lmmrssa]

Row selection and Rating bar for undefined is using same color. So rating bar seems hidden when row is selected.

[paulbert]

As an added research task you could try to incorporate the new color into _variables.scss using the Material theming. You can use hue 200 or 300 for the new color and please use the new color on the rating bar only

[samuelchen1213]

@paulbert I have added a new hue to _variables.scss, but I was wondering which file I have to use this hue. I checked the scss and html files in view-courses and I am confused on where to change the colour. Thank you for the help!

[lmmrssa]

@samuelchen1213

planet/src/app/shared/forms/planet-rating.component.ts

Line 75 in baf89fa

{ class: 'primary-light-color',

is adding class .primary-light-color to stack-bar. Class is defined on styles.scss

If you have created new class then change given line on planet-rating.component.ts to use new class. Or you can just change .primary-light-color class background-color on styles.scss

NOTE: Please do not change mat-table .highlight style

[samuelchen1213]

@lmmrssa Thank you very much!

[paulbert]

@samuelchen1213 Thinking about the naming for this a little more, I think the new hue should use the primary-light-color name and we should refactor so the other hue uses the term lighter. Please make this change for both the primary and the accent light variables. Let me know if you have any questions about this change.

Also, I didn't mention it during the meeting but we like to see code early and often! As a general rule we say you should push your changes once you finish in a coding session and create a PR if you haven't already. You can add the WIP label to let us know that you're still working on it, but it makes it easier for us to help you with questions or see if you are going in the wrong direction early.