Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use multiple translation #1155

Merged
merged 22 commits into from
Jun 20, 2018
Merged

use multiple translation #1155

merged 22 commits into from
Jun 20, 2018

Conversation

empeje
Copy link
Contributor

@empeje empeje commented May 29, 2018

fix #38

What I've done?

  • Fixed xlf file a little bit
  • Changed the Dockerfile to build multiple languages with certain base-href
  • Changed docker-entrypoint.sh to grep all the target languages

Working examples:
screen shot 2018-06-21 at 2 00 50 am
screen shot 2018-06-21 at 2 00 59 am

@@ -6,14 +6,22 @@ COPY package.json ./
RUN npm i --silent

COPY . .
RUN $(npm bin)/ng build --prod
RUN $(npm bin)/ng build --prod --output-path=dist-ar --aot --i18n-file=src/i18n/messages.ar.xlf --locale=ar i18n-format=xlf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ng build --prod --output-path=dist-ar --aot --i18n-file=src/i18n/messages.ar.xlf --i18n-locale=ar --i18n-format=xlf

@empeje
Copy link
Contributor Author

empeje commented Jun 3, 2018

Hi @paulbert, is the build command ready in the master branch? If yes, I'll do rebase.

@lmmrssa
Copy link
Member

lmmrssa commented Jun 12, 2018

This issue should be related to it #464

@empeje
Copy link
Contributor Author

empeje commented Jun 12, 2018

Thanks @lmmrssa

@paulbert
Copy link
Member

Note: We'll have to change the file names once the three letter code change for CrowdIn takes effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate (Multilanguage)
3 participants