Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rating snackbar fix #1830

Open
ArashDai opened this issue Aug 13, 2018 · 1 comment
Open

rating snackbar fix #1830

ArashDai opened this issue Aug 13, 2018 · 1 comment

Comments

@ArashDai
Copy link
Member

when leaving a rating for a course or resource there are 2 minor issues, 1. a snack-bar tells you your rating has been submitted before pressing submit, 2. whether or not you leave a comment it says thank you for additional comments.

@lmmrssa
Copy link
Member

lmmrssa commented Aug 14, 2018

@ArashDai Rating is already done this popup is only for comment. So point 1 is not intended to be. For point 2 yes we should only show message if additional comment is there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants