Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build time increased #1417

Closed
lmmrssa opened this issue Jun 21, 2018 · 6 comments
Closed

Build time increased #1417

lmmrssa opened this issue Jun 21, 2018 · 6 comments
Assignees

Comments

@lmmrssa
Copy link
Member

lmmrssa commented Jun 21, 2018

After we merged multi language, build time increased. Will it be possible to shrink it. Or have multi language build for certain commit case only and for other have only built english.

@empeje
Copy link
Contributor

empeje commented Jun 21, 2018

On it, sorry for the inconvenient.

Hint: https://docs.travis-ci.com/user/conditional-builds-stages-jobs/

@empeje
Copy link
Contributor

empeje commented Jun 21, 2018

When I try to fix this issue I have a question:

  • Do we want to have another kind of image: treehouses/planet:i18n-latest? Which contains build with multi-language and let treehouses/planet:latest same like before?

@lmmrssa
Copy link
Member Author

lmmrssa commented Jun 22, 2018

@mappuji I don't think we should have that, as it will be better to have latest as production release and production release should have multi language

@empeje
Copy link
Contributor

empeje commented Jun 22, 2018

Okay, if that's the expected solution, it will be simpler. I'll finish it soon. Thanks for clarification @lmmrssa

@empeje
Copy link
Contributor

empeje commented Jun 23, 2018

Two approaches:

See

@empeje
Copy link
Contributor

empeje commented Jun 28, 2018

Solved in #1444

@empeje empeje closed this as completed Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants