Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There are some errors in custom-validator.ts and course-validator.service.ts when running ng test #110

Closed
lucy811 opened this issue Oct 23, 2017 · 6 comments · Fixed by #125
Closed

There are some errors in custom-validator.ts and course-validator.service.ts when running ng test #110

lucy811 opened this issue Oct 23, 2017 · 6 comments · Fixed by #125
Assignees
@lucy811

Comments

@lucy811
Copy link
Member

lucy811 commented Oct 23, 2017

When I run ng test, there are some errors.
errors
Could anyone check it?
@midsorbet
Copy link
Contributor

Are you importing the rxjs operator from here?

@lucy811
Copy link
Member Author

lucy811 commented Oct 23, 2017

I tried to add "import '.share/rxjs-imports.ts';" in the course-validator.service.spec.ts , the errors still exist.

@midsorbet
Copy link
Contributor

I think it will work if you import it in the app.component.spec.ts

@lucy811
Copy link
Member Author

lucy811 commented Oct 23, 2017

@LKhadka Thank you . I have tried it . No errors now.

@midsorbet
Copy link
Contributor

No problem @lucy811. @paulbert Do you think a PR should be made to import the rxjs operators to app.component.spec.ts?

@lucy811
Copy link
Member Author

lucy811 commented Oct 25, 2017

@LKhadka @paulbert I can make a PR for this. Thanks

@lucy811 lucy811 self-assigned this Oct 25, 2017
@lucy811 lucy811 mentioned this issue Oct 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucy811 lucy811

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@midsorbet @empeje @lucy811