-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate VGG19 models #93
Comments
"The VGG19 in the model zoo generated from caffe2" That would be enough. |
@snnn thanks for the explanation |
That's pretty confusing for the users of the zoo to have 2 different versions of the model. Which one should they use and why? |
probably we can have some evaluation. And only keep one. |
we don't even link to both from the TOC so one of the models is "hidden". |
Adding on here that this is also captured by #82 |
@prasanthpul @crahrig The models listed #82 were in the model zoo before the need for all the artifacts was standardized. Previous models : |
Hi @ankkhedia , Is there any update on this bug: #91 ? Does it only affect the resnet100 model? Thanks. |
Thank you @ankkhedia |
@snnn @ankkhedia @prasanthpul @houseroad have we reached consensus on this? either 1) merge and keep only one model or 2) keep both, group in same folder, and differentiate based on training framework used ? |
The VGG19 model from mxnet seems having some problems. The input of a GEMM op is not a 2-D tensor. |
This should be fixed with PR apache/mxnet#13356. |
So, someone will update the models here? |
@snnn I will update the models after generating them with this fix. |
The actual issue seems to be there are duplicate VGG19 models in the zoo (see above). How does "updating" the files resolve this issue? Shouldn't one set be removed or the |
@lutzroeder This is about @snnn comment about issues with MXNet generated models. @prasanthpul any thoughts on the same? |
@snnn The models has been uploaded after the fix. Please feel free to verify and let us know in case of any issues |
There are two different
VGG19
models in the model zoo. Can the files be consolidated or renamed so users referring to "VGG19 in the model zoo" will be less ambiguous.https://github.com/onnx/models/tree/master/vgg19
https://github.com/onnx/models/tree/master/models/image_classification/vgg
The text was updated successfully, but these errors were encountered: