Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After the Goss tests are ran in PR workflow, the image should get build for all platforms #25

Closed
onedr0p opened this issue Jun 29, 2022 · 0 comments
Closed

After the Goss tests are ran in PR workflow, the image should get build for all platforms #25

onedr0p opened this issue Jun 29, 2022 · 0 comments

Comments

@onedr0p
Copy link
Owner

onedr0p commented Jun 29, 2022 •
edited
Loading

Currently we only build amd64 image and test that with Goss, that leaves a hole for testing arm64 builds which could fail for whatever reason. We cannot test them with Goss but we could at least try to build them (with push: false) and see if the build is success or failure.

This would save us from merging in PRs where the arm64 build for whatever reason fails to build. I encountered this issue with upx not being in the arm64 alpine registry.
@onedr0p onedr0p changed the title After Goss test is ran in PR workflow, the image should get build by all platforms After the Goss tests are ran in PR workflow, the image should get build for all platforms Jun 29, 2022
@onedr0p onedr0p closed this as completed Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@onedr0p