From e09755da3acb02958e315c899565f1785faa8d32 Mon Sep 17 00:00:00 2001 From: Erik Desjardins Date: Thu, 30 Aug 2018 13:01:40 -0400 Subject: [PATCH] remove @babel/plugin-proposal-export-default-from (#4840) Flow can't parse this syntax so we can't use it anyways. Also, the equivalent syntax: `export Foo from './foo'` -> `export { default as Foo } from './foo'` isn't much longer and is clearer IMO (i.e. does the first one export something called `Foo` or the default export?) --- .babelrc | 1 - package.json | 1 - webpack.config.babel.js | 1 - yarn.lock | 13 ------------- 4 files changed, 16 deletions(-) diff --git a/.babelrc b/.babelrc index ea68f4fcd8..a34bf100f8 100644 --- a/.babelrc +++ b/.babelrc @@ -1,6 +1,5 @@ { "plugins": [ - "@babel/plugin-proposal-export-default-from", "@babel/plugin-proposal-export-namespace-from", ["@babel/plugin-proposal-class-properties", { "loose": true }], ["@babel/plugin-proposal-object-rest-spread", { "loose": true, "useBuiltIns": true }], diff --git a/package.json b/package.json index f3aef402c7..4f767a93d3 100644 --- a/package.json +++ b/package.json @@ -76,7 +76,6 @@ "devDependencies": { "@babel/core": "7.0.0", "@babel/plugin-proposal-class-properties": "7.0.0", - "@babel/plugin-proposal-export-default-from": "7.0.0", "@babel/plugin-proposal-export-namespace-from": "7.0.0", "@babel/plugin-proposal-object-rest-spread": "7.0.0", "@babel/plugin-transform-flow-strip-types": "7.0.0", diff --git a/webpack.config.babel.js b/webpack.config.babel.js index 4a5e7a4364..6409aabf45 100644 --- a/webpack.config.babel.js +++ b/webpack.config.babel.js @@ -74,7 +74,6 @@ export default (env = {}, argv = {}) => { loader: 'babel-loader', options: { plugins: [ - '@babel/plugin-proposal-export-default-from', '@babel/plugin-proposal-export-namespace-from', ['@babel/plugin-proposal-class-properties', { loose: true }], ['@babel/plugin-proposal-object-rest-spread', { loose: true, useBuiltIns: true }], diff --git a/yarn.lock b/yarn.lock index 64bc7fe8a3..3a23c37e47 100644 --- a/yarn.lock +++ b/yarn.lock @@ -269,13 +269,6 @@ "@babel/helper-replace-supers" "^7.0.0" "@babel/plugin-syntax-class-properties" "^7.0.0" -"@babel/plugin-proposal-export-default-from@7.0.0": - version "7.0.0" - resolved "https://registry.yarnpkg.com/@babel/plugin-proposal-export-default-from/-/plugin-proposal-export-default-from-7.0.0.tgz#a057bbfd4649facfe39f33a537e18554bdd2b5da" - dependencies: - "@babel/helper-plugin-utils" "^7.0.0" - "@babel/plugin-syntax-export-default-from" "^7.0.0" - "@babel/plugin-proposal-export-namespace-from@7.0.0": version "7.0.0" resolved "https://registry.yarnpkg.com/@babel/plugin-proposal-export-namespace-from/-/plugin-proposal-export-namespace-from-7.0.0.tgz#ce847cc62c3626547107a1b835592b8ee494af51" @@ -309,12 +302,6 @@ dependencies: "@babel/helper-plugin-utils" "^7.0.0" -"@babel/plugin-syntax-export-default-from@^7.0.0": - version "7.0.0" - resolved "https://registry.yarnpkg.com/@babel/plugin-syntax-export-default-from/-/plugin-syntax-export-default-from-7.0.0.tgz#084b639bce3d42f3c5bf3f68ccb42220bb2d729d" - dependencies: - "@babel/helper-plugin-utils" "^7.0.0" - "@babel/plugin-syntax-export-namespace-from@^7.0.0": version "7.0.0" resolved "https://registry.yarnpkg.com/@babel/plugin-syntax-export-namespace-from/-/plugin-syntax-export-namespace-from-7.0.0.tgz#17a7389a1d2571ac4d9b77ea2defa74a930edf5d"