-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parseOptions strips characters after "]" #4127
Comments
This issue has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/omero-fiji-plugin-error-invalid-image-id/89470/12 |
Oh wow 👏🏽 |
Thank you very much @CFGrote . I'm surprised that this is handed down to and fails at the Bioformats level, as all the authentication and transfer is done on the OMERO level. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bioformats version 7.0.1
This bug report is related to ImageSc post https://forum.image.sc/t/omero-fiji-plugin-error-invalid-image-id/89470/11.
In brief, the fiji-omero plugin reports an error (loci.formats.FormatException: Invalid image ID) when opening an image from our institute's omero. this issue was observed by some users but not by all.
Attaching jdb to a running Fiji process, I narrowed it down to the following:
Stopping in bioformats'
loci.plugins.in.Importer.parseOptions()
, line 127Note the password: It has a "]", likely closing the opening "[" after "open=".
Then, in line 132:
So somewhere in between, everything after the "]" in my password must have been stripped away,
including the Image ID, causing the exception in the Fiji plugin.
I hope this can be fixed.
Something else that strikes me is that passwords seem to be passed as plain text, but is this really necessary?
Shouldn't the image id be all that is needed to query the image and send it to Fiji?
But maybe there are other use cases where this information is actually needed.
The text was updated successfully, but these errors were encountered: