Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Object.create #7

Closed
jzaefferer opened this issue Sep 20, 2011 · 2 comments
Closed

Add Object.create #7

jzaefferer opened this issue Sep 20, 2011 · 2 comments

Comments

@jzaefferer
Copy link

Only adds 10 LOC: https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Object/create

Or was there a reason to exclude it? There are Object extensions already, so...

@olivernn
Copy link
Owner

I've had a couple of requests for adding Object.create into augment. I'm reluctant to do so because it isn't possible (to my knowledge) to fully implement this method in JavaScript.

I don't think adding a half implemented version of Object.create is something that augment should be doing. All the other methods that augment adds are nearly identical to their native counterparts, which makes it possible to just start using them now and forget about browser support. This wouldn't be possible with the proposed implementation of Object.create.

@jzaefferer
Copy link
Author

Okay, just noticed that second argument now. Guess I'll just put that simple implementation into my app then.

Maybe add a note about it to the readme, so that people can stop creating new tickets?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants