Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Score-P #181

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Score-P #181

wants to merge 27 commits into from

Conversation

gmarkomanolis
Copy link
Contributor

Preparing the material for Score-P tutorial

@gmarkomanolis gmarkomanolis marked this pull request as ready for review February 27, 2020 17:14
@gmarkomanolis gmarkomanolis changed the title WIP: Score-P Score-P Mar 27, 2020
@jack-morrison jack-morrison self-assigned this Mar 30, 2020
@jack-morrison
Copy link
Contributor

jack-morrison commented Mar 30, 2020

Hey @gmarkomanolis -- Thanks for putting this together!

I started reviewing this today, and unfortunately it looks like MiniWeather has moved to a CMake build system after this MR was open as a draft. Would you mind updating the instrumentation example(s) to match how MiniWeather is built now? I started doing so in 81be937.

I also noticed that the following two sections are only code snippets:
Automatic Source Code Instrumentation > Prefix method
Automatic Source Code Instrumentation > Wrapper method

Could you add a blurb about the difference between these two methods?

You'll see in 0e1eceb there's quite a bit of table reformatting, which was just to bring things into alignment and emphasize values as in-lined code. This commit also added Score-P into the menus, which required a rename of the .rst file.

Thanks again! Happy to finally be getting this one published.

@jack-morrison jack-morrison removed their assignment May 26, 2020
@arghyac007 arghyac007 assigned arghyac007 and unassigned arghyac007 Jun 23, 2020
@arghyac007 arghyac007 self-requested a review June 23, 2020 20:50
@arghyac007 arghyac007 self-assigned this Jun 23, 2020
@gmarkomanolis gmarkomanolis removed the request for review from arghyac007 July 30, 2020 18:23
@arghyac007 arghyac007 removed their assignment Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants