Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image filter with giff not working #10

Open
Loocos opened this issue Aug 12, 2021 · 3 comments
Open

Image filter with giff not working #10

Loocos opened this issue Aug 12, 2021 · 3 comments

Comments

@Loocos
Copy link

Loocos commented Aug 12, 2021

Hi,

It is possible to support giff images ?
Upload is working well, but the filtering applied isn't working. Make the giff static.

Thank you

@bigboss86
Copy link
Collaborator

Hi @Loocos. We are using LiipImagineBundle for image manipulation as Sylius recommends. Apparently they have an unresolved bug about that:
liip/LiipImagineBundle#1066

@Loocos
Copy link
Author

Loocos commented Aug 16, 2021

@bigboss86 What if we handle the case of gif in order to render the asset as {{ asset(banner.imageName) }} instead of {{ banner.imageName|liip_imagine('...') }}
What do you think ? It can be better than render a giff as static image

@bigboss86
Copy link
Collaborator

@Loocos Great idea. Feel free to contribute and open a PR.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants