Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI builds for Lwt contributors #377

Closed
aantron opened this issue May 24, 2017 · 1 comment
Closed

Fix CI builds for Lwt contributors #377

aantron opened this issue May 24, 2017 · 1 comment
Labels

Comments

@aantron
Copy link
Collaborator

aantron commented May 24, 2017

Some contributors have set up CI testing in their own GH forks of the repo, e.g. in #367 and #347. It seems that their builds don't work until they add sudo: required to their .travis.yml, e.g. d198a2b.

I am not sure why the main repo's builds are working without that line. Perhaps they are getting grandfathered in after some breaking change in Travis, which the Lwt build predates. I guess we should just add sudo: required to the main .travis.yml, and make sure everything is working.

This issue is basically about making that change, opening a PR against the main repo, and waiting to make sure the builds don't break. To avoid triggering the AppVeyor builds, one can add [skip appveyor] to the commit message.

I want to note for contributors, that it's okay to submit a PR to the main repo, and just use it for triggering CI builds while still developing the change – just add a note in the PR that it's not ready for review. However, we shouldn't annoy people who choose to set up their own CI builds for whatever reason.

EDIT: cc @jsthomas @domsj

@persianturtle
Copy link
Contributor

I'll take care of this one.

@aantron aantron added the easy label May 24, 2017
persianturtle pushed a commit to persianturtle/lwt that referenced this issue May 24, 2017
Resolves ocsigen#377.

[skip appveyor]
persianturtle added a commit to persianturtle/lwt that referenced this issue May 24, 2017
Resolves ocsigen#377.

[skip appveyor]
aantron pushed a commit that referenced this issue May 24, 2017
Resolves #377.

[skip appveyor]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants