Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

un-deprecate Lwt_result #320

Closed
c-cube opened this issue Feb 27, 2017 · 7 comments
Closed

un-deprecate Lwt_result #320

c-cube opened this issue Feb 27, 2017 · 7 comments
Assignees

Comments

@c-cube
Copy link
Collaborator

c-cube commented Feb 27, 2017

I still don't really understand why the module was deprecated, but the more I use lwt the more I can't bear with exception-based error handling in it. I think a well-developped, convenient Lwt_result module is critical for good error handling. Can we use this issue to discuss the future of Lwt_result then?

@samoht
Copy link

samoht commented Feb 27, 2017

I concur. This is a very useful module which does not have other counter parts in the library ecosystem.

@aantron
Copy link
Collaborator

aantron commented Feb 28, 2017

FWIW, I gave this a +1, but I have to delay making a positive decision on this due to time constraints. Any links for future reading, libraries that do this right (probably Async), in-depth discussion, etc., appreciated.

@agarwal
Copy link
Contributor

agarwal commented Feb 28, 2017

Related modules from Async:

  • Deferred.Result
  • Deferred.Or_error.List. For some reason there is no Deferred.Result.List, which could be easily provided and would be more general than Deferred.Or_error.List. In case you don't know: 'a Or_error.t = ('a, Error.t) Result.t.

aantron referenced this issue Mar 2, 2017
Did not annotate Lwt_sequence for the time being, as it is still used by
the Lwt API.

Closes #107.
@c-cube c-cube closed this as completed in ce9b201 Mar 6, 2017
@c-cube
Copy link
Collaborator Author

c-cube commented Mar 6, 2017

For those interested, follow-up design issues in #324.

@aantron
Copy link
Collaborator

aantron commented Mar 6, 2017

Thanks!

@tte
Copy link

tte commented Jun 26, 2017

@aantron Hello! So what is a replacement for Lwt_result? I was really excited to using this module instead of spaghetti-code checks w/ Lwt.Infix and Result monads. But I can't compile, run CI w/ -warn-error flag now. Why this (experimental) module is deprecated and what is a replacement for?

@aantron
Copy link
Collaborator

aantron commented Jun 26, 2017

@tte this module is not deprecated or experimental since Lwt 2.7.1 (April). It is a supported part of Lwt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants