Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lwt_unix.files_of_directory is very slow #290

Open
samoht opened this issue Nov 14, 2016 · 0 comments
Open

Lwt_unix.files_of_directory is very slow #290

samoht opened this issue Nov 14, 2016 · 0 comments
Milestone

Comments

@samoht
Copy link

samoht commented Nov 14, 2016

I noticed that Lwt_unix.files_of_directory is always slower that call directly Unix.readdir. Usually it's 2 or 3 times slower, but on some contrived examples I managed to get a 6x slowdown.

I have created https://github.com/samoht/repros/blob/master/readdir.ml to reproduce the issue. Lwt_stream operations seem to make things go slower, as well as the unnecessary allocations done in readdir_n as spotted by @yallop.

@aantron aantron self-assigned this Nov 20, 2016
@aantron aantron removed their assignment Nov 23, 2016
@aantron aantron added the medium label May 20, 2017
@aantron aantron added this to the libuv milestone Aug 3, 2019
@aantron aantron removed the medium label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants