-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@oclif/test v4 runCommand
segFaults on linux node < 18.20.0 and < 20.8.0
#556
Comments
@zmully Can you create a repository that replicates the issue? |
Hmm. So there is something weird going on between So github.com/zmully/oclif-test-mocha works fine with the But github.com/zmully/oclif-test-jest segfaults when the I don't really know where to look next, but please let me know if you're also getting segfaults with jest repository... |
@zmully I believe this is related to jest's ESM support since plugin-warn-if-update is ESM and the tests seem to be failing when attempting to import a path from the plugin. You might be able to figure out how to workaround it by following either of these guides: I don't have bandwidth to figure it out but if you do, it'd be great if you could post it here so that others can see. Also worth noting that you can workaround this issue by either downgrading plugin-warn-if-update to v2 (which isn't ESM) or use a newer version of node (v20.13.1 is working for me) |
Describe the bug
Updated our internal cli to use
@oclif/[email protected]
and the newrunCommand
segFaults on linux node < 18.20.0 and <20.8.0. I've replicated this on linux x86 and linux arm. This does not happen on macOS for any versions of 18.x or 20.x that I spot tested.To Reproduce
Steps to reproduce the behavior:
runCommand
method:await expect(runCommand<{ name: string }>(['jira:watch', '-p', 'plat'])).resolves.not.toThrow();
and it segfaults when executed using any of the above node versions.If I switch the test and execute the command directly, the test passes:
await expect(JiraWatchIssues.run(['-p', 'plat'])).resolves.not.toThrow();
This is not command specific, it segFaults if I execute the default oclif
help
command:await expect(runCommand<{ name: string }>(['help'])).resolves.not.toThrow();
Environment (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: