Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: oclif/plugin-help version 3 #64

Merged
merged 6 commits into from
Apr 27, 2020
Merged

feat: oclif/plugin-help version 3 #64

merged 6 commits into from
Apr 27, 2020

Conversation

chadian
Copy link
Contributor

@chadian chadian commented Apr 27, 2020

This pull request will add be considered a breaking change and bump oclif/plugin-help to version3. It includes:

  • custom help classes
  • re-worked Help class for easier extensibility
  • splitting children previously under the COMMANDS list into separate TOPICS and COMMANDS lists

@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #64 into master will increase coverage by 9.04%.
The diff coverage is 87.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   74.53%   83.58%   +9.04%     
==========================================
  Files           7        8       +1     
  Lines         271      335      +64     
  Branches       81       88       +7     
==========================================
+ Hits          202      280      +78     
+ Misses         32       22      -10     
+ Partials       37       33       -4     
Impacted Files Coverage Δ
src/command.ts 89.33% <ø> (+2.66%) ⬆️
src/_test-help-class.ts 42.85% <42.85%> (ø)
src/commands/help.ts 66.66% <50.00%> (-6.67%) ⬇️
src/index.ts 90.82% <91.66%> (+26.93%) ⬆️
src/util.ts 92.85% <94.11%> (+0.85%) ⬆️
src/list.ts 78.43% <0.00%> (+1.96%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3568e0...61da89c. Read the comment docs.

@chadian chadian changed the title oclif/plugin-help version 3 feat: oclif/plugin-help version 3 Apr 27, 2020
Copy link
Contributor

@RasPhilCo RasPhilCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants