Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine-grained control over --strict #5722

Open
dra27 opened this issue Nov 9, 2023 · 0 comments
Open

Fine-grained control over --strict #5722

dra27 opened this issue Nov 9, 2023 · 0 comments

Comments

@dra27
Copy link
Member

dra27 commented Nov 9, 2023

The num library's GitHub Actions pipeline performs a test opam install --strict num. It uses --strict in order to test the num.install file generated by its build system is valid (during work on ocaml/num#33, opam install num will merrily install nothing if num.install is corrupt).

The with-dev-setup filter variable added in #5160 / #5214 has started being used in ocaml/opam-repository#24484 which is causing the workflow to fail:

<><> Synchronising pinned packages ><><><><><><><><><><><><><><><><><><><><><><>
[NOTE] Ignoring uncommitted changes in /home/runner/work/num/num (`--working-dir' not active).
[num.1.5~dev] synchronised (git+file:https:///home/runner/work/num/num#master)

[ERROR] undefined filter variable in dependencies of ambient-context.0.1.0: with-dev-setup
Error: Process completed with exit code 3

This is being worked around in ocaml/num#36 to use the opam 2.2 pre-releases. The problem will of course disappear when opam 2.2 is released, but it would be useful to be able to limit exactly what --strict is applied to.

@dra27 dra27 added this to the 2.3 milestone Nov 9, 2023
@kit-ty-kate kit-ty-kate modified the milestones: 2.3.0~alpha, 2.4.0~alpha1 Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants