Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opam lint: a command line flag to make opam lint return 1 on warnings #5651

Closed
Niols opened this issue Sep 4, 2023 · 3 comments · Fixed by #5652
Closed

opam lint: a command line flag to make opam lint return 1 on warnings #5651

Niols opened this issue Sep 4, 2023 · 3 comments · Fixed by #5652
Labels
KIND: FEATURE WISH
Projects
Opam 2.2.0
Milestone
2.2.0~alpha3

Comments

@Niols
Copy link

Niols commented Sep 4, 2023

opam lint can report either errors or warnings. Currently, the return code of the command is 1 if there were errors and 0 if there weren't any (including if there were warnings). I would like a command line flag to either make warnings become errors or to make the return code be 1 also on warnings.

I “discovered” this behaviour when I realised that my CI running opam lint wasn't catching warnings and that I needed a fancier test involving reading the standard output of opam lint.
@kit-ty-kate kit-ty-kate mentioned this issue Sep 4, 2023
Merged
@kit-ty-kate
Copy link
Member

I've open a PR to allow marking warnings as errors in #5652

@Niols
Copy link
Author

Niols commented Sep 5, 2023

Oh wow, very nice, thank you!

@kit-ty-kate kit-ty-kate added this to the 2.2.0~alpha3 milestone Sep 12, 2023
@kit-ty-kate kit-ty-kate added this to Done in Opam 2.2.0 Sep 12, 2023
@Niols
Copy link
Author

Niols commented Sep 12, 2023

Impressive; thank you! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
KIND: FEATURE WISH
Projects
No open projects
Opam 2.2.0
  
Done
Milestone
2.2.0~alpha3
Development

Successfully merging a pull request may close this issue.

opam lint: Allow to mark a set of warnings as errors kit-ty-kate/opam
2 participants
@kit-ty-kate @Niols