Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve local links #323

Closed
Fil opened this issue Dec 5, 2023 · 3 comments
Closed

Resolve local links #323

Fil opened this issue Dec 5, 2023 · 3 comments
Assignees
@Fil
Labels
enhancement New feature or request

Comments

@Fil
Copy link
Contributor

Fil commented Dec 5, 2023 •
edited
Loading

e.g. [plot](/lib/plot) from the /lib/arquero page should link to ./plot not /lib/plot.
@Fil Fil added the enhancement New feature or request label Dec 5, 2023
@Fil Fil self-assigned this Dec 5, 2023
@mbostock mbostock changed the title fix local links Resolve local links Dec 5, 2023
@mbostock
Copy link
Member

mbostock commented Dec 10, 2023 •
edited
Loading

This is closely related to #92. If we rewrite local links, we can not only normalize them to relative paths, but we can also replace the .md extension with .html or remove it based on a user setting. This issue would also let us detect broken links and break the build.

@Fil
Copy link
Contributor Author

Fil commented Dec 11, 2023

loosely linked to #363

@mbostock mbostock added this to the Future milestone Jan 16, 2024
@mbostock mbostock removed this from the Future milestone Mar 24, 2024
@Fil
Copy link
Contributor Author

Fil commented Jun 24, 2024

solved in #1306 (by 791a59c)

@Fil Fil closed this as completed Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fil Fil

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fil @mbostock