Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imports within inline expressions aren’t preloaded #123

Closed
mbostock opened this issue Nov 8, 2023 · 0 comments · Fixed by #120
Closed

Imports within inline expressions aren’t preloaded #123

mbostock opened this issue Nov 8, 2023 · 0 comments · Fixed by #120
Assignees
Labels
bug Something isn’t working

Comments

@mbostock
Copy link
Member

mbostock commented Nov 8, 2023

For example:

${await import("./test.js").then((module) => module.default)}

Here we expect /_file/test.js to be preloaded, but it’s not, because makePlaceholderRenderer is forgetting to copy the transpile.imports into the context.imports.

@mbostock mbostock added the bug Something isn’t working label Nov 8, 2023
@mbostock mbostock self-assigned this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn’t working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant