Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roles doing stuff where entities should be? #1

Open
dosumis opened this issue Feb 7, 2014 · 1 comment
Open

Roles doing stuff where entities should be? #1

dosumis opened this issue Feb 7, 2014 · 1 comment

Comments

@dosumis
Copy link

dosumis commented Feb 7, 2014

It seems odd to have roles rather than entities inhibiting, activating etc.

e.g. '4-aminobutyrate transaminase inhibitor' (a CHEBI ROLE) EquivalentTO 'biological role'
and (inhibitor_of some '4-aminobutyrate transaminase activity')

This could work:

'chemical entity' that has_role some 4-aminobutyrate transaminase inhibitor' EquivalentTo inhibitor_of some '4-aminobutyrate transaminase activity'

But perhaps harder to maintain, in which case GO(CHE) style bridging classes might be a good idea.

Alternatively, in the spirit of the BFO conception of this, we might say

4-aminobutyrate transaminase inhibitor (role) EquivalentTo: realised_by some* (inhibition_of some 4-aminobutyrate transaminase activity')

(*only ??? - I don't think this is necessary if roles can be bourne without being realised)

Or combining with a typical GO way of doing things:

4-aminobutyrate transaminase inhibitor (role) EquivalentTo: realised_by some 'negative regulation of 4-aminobutyrate transaminase activity')

Perhaps some use case queries would help clarify the preferred approach.

@cmungall
Copy link
Member

  • = I think it formally needs to be "only". Otherwise every instance of the chemical entails the existence of a process. I don't think this is problematic for various formal and pragmatic reasons but others may object.

I'd rather keep it EL for the first pass, so at some stage we should auto-transform all of these to the pattern you suggest.

  • also inhibition -> regulation (current snapshot is partly a reflection of the semi-automated methods used to construct)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants