-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roles doing stuff where entities should be? #1
Comments
I'd rather keep it EL for the first pass, so at some stage we should auto-transform all of these to the pattern you suggest.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems odd to have roles rather than entities inhibiting, activating etc.
e.g. '4-aminobutyrate transaminase inhibitor' (a CHEBI ROLE) EquivalentTO 'biological role'
and (inhibitor_of some '4-aminobutyrate transaminase activity')
This could work:
'chemical entity' that has_role some 4-aminobutyrate transaminase inhibitor' EquivalentTo inhibitor_of some '4-aminobutyrate transaminase activity'
But perhaps harder to maintain, in which case GO(CHE) style bridging classes might be a good idea.
Alternatively, in the spirit of the BFO conception of this, we might say
4-aminobutyrate transaminase inhibitor (role) EquivalentTo: realised_by some* (inhibition_of some 4-aminobutyrate transaminase activity')
(*only ??? - I don't think this is necessary if roles can be bourne without being realised)
Or combining with a typical GO way of doing things:
4-aminobutyrate transaminase inhibitor (role) EquivalentTo: realised_by some 'negative regulation of 4-aminobutyrate transaminase activity')
Perhaps some use case queries would help clarify the preferred approach.
The text was updated successfully, but these errors were encountered: