Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't fully hide dialog element (breaks nature.com, link.springer.com, biomedcentral.com etc...) #282

Open
moddular opened this issue Jun 10, 2024 · 0 comments

Comments

@moddular
Copy link

The cookie banner on nature.com link.springer.com etc... gets hidden I suspect because it matches the .cc-banner selector from https://github.com/oblador/hush/blob/master/data/vendor/fanboy-cookiemonster.txt

However, because the banner is a dialog element setting it as display: none only hides the content of the banner and still leaves the Top Layer created by the dialog covering the page and preventing any clicks from working.

I think the correct handling for a dialog might be to trigger it's close method instead of setting the display?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant