Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

Remove Array.prototype.diff prototype augmentation #7

Closed
GeeWee opened this issue May 19, 2019 · 2 comments
Closed

Remove Array.prototype.diff prototype augmentation #7

GeeWee opened this issue May 19, 2019 · 2 comments

Comments

@GeeWee
Copy link

GeeWee commented May 19, 2019

In sync.js we're augmenting array with Array.prototype.diff
This can break other extensions looping over arrays (see e.g. gTile/gTile#22 (comment))

I think it would be best to remove the prototype augmentation, it's widely considered a bad idea in environments where code have to share a runtime.

@oae oae closed this as completed in b68b4c2 Sep 22, 2019
@oae
Copy link
Owner

oae commented Sep 22, 2019

thank you for the feedback. I have removed it and will release it in the next version

@GeeWee
Copy link
Author

GeeWee commented Sep 23, 2019

Awesome! Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants