Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPL-3.0-or-later licenses wrongly reported as GPL-3.0-only #1251

Open
1 task done
streaksu opened this issue Jan 9, 2024 · 4 comments
Open
1 task done

GPL-3.0-or-later licenses wrongly reported as GPL-3.0-only #1251

streaksu opened this issue Jan 9, 2024 · 4 comments
Labels
bug Something isn't working upstream

Comments

@streaksu
Copy link

streaksu commented Jan 9, 2024

Duplicates

  • I have searched the existing issues

Current behavior 😯

License: GPL-3.0-only

Expected behavior 🤔

License: GPL-3.0-or-later

Steps to reproduce 🕹

  1. Clone a GPL-3.0-or-later repository (for example: https://git.savannah.gnu.org/git/ironclad.git)
  2. onefetch inside
  3. Wrong result is shown

Additional context/Screenshots 🔦

Effectively reopening #769, which said to fix the issue, but as of onefetch 2.19.0 it still is reproducible

Possible Solution 💡

To my knowledge, the or-later is determined by the license headers in the files. If scanning the licensed files is impractical to determine the or-later, maybe removing the only in the license printed helps remove a degree of confusion.

@streaksu streaksu added the bug Something isn't working label Jan 9, 2024
@o2sh o2sh added the upstream label Jan 9, 2024
@o2sh
Copy link
Owner

o2sh commented Jan 9, 2024

It's an upstream issue jpeddicord/askalono#45 (comment)

As a quick workaround, I see two options:

  • As suggested in Wrong license detected: GPL-3.0-only #769, get the license value from the package manifest first (only works for Cargo.toml or pakage.json) -> already implemented
  • In doubt (presence of aliases) show both licenses to the user, smth like License: GPL-3.0-or-later | GPL-3.0-only

@spenserblack
Copy link
Collaborator

spenserblack commented Jan 9, 2024

So the "or later" is really only known by comments in the source code, and the docs referencing "1.3 or any later version", right?

Have there been any projects that mix "only" and "later"?

@o2sh
Copy link
Owner

o2sh commented Jan 9, 2024

For reference, it seems like the library used by github for license detection has the same issue licensee/licensee#406 and their solution matches @streaksu's suggestion

@spenserblack
Copy link
Collaborator

Perhaps Askolono can also report simplified names (e.g. gpl-3.0-* -> GPL 3.0) as an additional field if it doesn't already? And then we could use those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream
Projects
None yet
Development

No branches or pull requests

3 participants