New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes_comments should have compound foreign key (file_id, hash) #23

Closed

nanokatze opened this issue Feb 1, 2017 · 2 comments

Labels

Contributor

nanokatze commented Feb 1, 2017 •

edited

Loading

There can exist same change hash for two or more different files. Example:

you open two files with exactly same content
their base changes are both 0
erase first 4 bytes in both
change hash is sha256(base + file_pos + change_type + data)
get collision

nanokatze added the bug label

Owner

nyxxxie commented Feb 7, 2017

@fst3a is this fixed with sqlalchemy changes in feature/implement_project?

Contributor Author

nanokatze commented Feb 7, 2017

nanokatze closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment