Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maximized frameless transparent window maintains right resize area exposed #6221

Closed
Yonezpt opened this issue Oct 21, 2017 · 4 comments
Closed

Maximized frameless transparent window maintains right resize area exposed #6221

Yonezpt opened this issue Oct 21, 2017 · 4 comments
Assignees
@jtg-gg
Labels
bug P2 triaged

Comments

@Yonezpt
Copy link

Yonezpt commented Oct 21, 2017

NWJS Version : SDK 0.26.0
Operating System : Win7 x64

Expected behavior

The right side of the window should not display a border and the cursor should not change when moving over it

Actual behavior

The right side of the window is displaying a border and when moving the cursor over it changes to the e-resize cursor, confirming that the right side resize is still in effect while maximized

How to reproduce

Basic app template with option to maximize.
Window must be set to transparent and frameless.
Using package.nw method

package.json

{
    "author": "test",
    "description": "test",
    "main": "index.html",
    "name": "test",
    "version": "1.0.0",
    "window": {
        "frame": false,
        "transparent": true
    }
}

index.html

<!DOCTYPE html>
<html style="background:rgba(0,0,0,0.5);height:100%">
    <head>
    </head>
    <body>
        <button onclick="resize();return false;">Click to maximize/restore</button>
        <script>
                var is_maximized = false;
                var gui = require("nw.gui");
                var win = gui.Window.get();

                win.on("restore", () => is_maximized = false);
                win.on("maximize", () => is_maximized = true);

                function resize() {
                    if (is_maximized) {
                        win.restore();
                    } else {
                        win.maximize();
                    }
                }
        </script>
    </body>
</html>

Short recording demonstrating the problem. The window is maximized and the right side has a white border, which cannot be seen in the GitHub white background, I suggest opening this recording in a window with a dark background.

ss
@Christywl
Copy link
Contributor

I can reproduce this issue on Windows 8.1 with nwjs-sdk-v0.26.0.

@Yonezpt Yonezpt mentioned this issue Oct 23, 2017
Closed
@jtg-gg jtg-gg assigned jtg-gg and unassigned rogerwang Oct 25, 2017
@jtg-gg jtg-gg mentioned this issue Oct 25, 2017
Closed
@jtg-gg
Copy link
Member

jtg-gg commented Oct 25, 2017

@rogerwang I've made a pull request nwjs/chromium.src#98
please also patch nw27

@rogerwang
Copy link
Member

This is fixed in git and will be available in the next nightly build.

@Yonezpt Yonezpt mentioned this issue Oct 30, 2017
Closed
@Yonezpt Yonezpt mentioned this issue Jan 24, 2018
Closed
@pols63
Copy link

pols63 commented Feb 26, 2022

Hi. It still happen to me in Windows 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jtg-gg jtg-gg

Labels
bug P2 triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rogerwang @jtg-gg @Yonezpt @Christywl @pols63