-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signal app always restarts setup wizard even it's already configured #5704
Comments
@onny sorry, I am not very clear about this description:
How should I do to reproduce? |
Thank you for your response.
Here are the steps to reproduce this issue:
Now the app starts like this To trigger the bug, close nwjs and Signal and start it again. Normally you should only see the chat window, like this: Thank you for your support and best regards, |
@onny thanks for your very clear description. |
@xzhan96 I'm using Signal app since nwjs version 0.16.1 and the bug was already present. I'm not aware of any nwjs version which doesn't have this bug. |
@onny if the issue also appear when Signal as Chrome App ? |
@xzhan96 No, in chrome/chromium everything works fine |
Bug still present using the latest versions:
|
I've created a patch for the signal app so that it will close the installer window after starting: |
@onny I change the below code in chromium.js
to
And then it works fine, that means the setup wizard only appears on first start up after Signal is installed. I am not sure this is correct, but from the google's document , I think onStartup is proper for your case? |
@xzhan96 changing it to |
@rogerwang got it. sorry, I just see your are investigating this issue. |
The root cause is that |
This is fixed in git and will be available in the next nightly build. |
@rogerwang could you link the patch? |
it's merged in the master patch in chromium repo. |
I just modified |
nice, thanks a lot. |
Thanks, this issue is fixed in the latest nightly 👍 |
Hey,
I'm using the crypto messenger Signal-Desktop 0.28.0 successfully with the latest stable nwjs version 0.20.2 on ArchLinux x86_64, installed as described here for Ubuntu or using the AUR buildscript.
The program runs fine and is usable but unfortunately the setup wizard also restarts every time I launch the app :( Here's the debug output:
That's how it looks like:
On the left there's the setup wizard and on the right there's the already configured programm running.
I'll look into further logging and debuging issues and maybe someone can help me here further!
Thanks and best regards,
Jonas
The text was updated successfully, but these errors were encountered: