Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: async job close not working #2797 #2798

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

Marskey
Copy link
Contributor

@Marskey Marskey commented Nov 27, 2023

Description

fix the ayncjob:close not actualy close the process

Fixes #2797

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list relevant details about your configuration

local uv = vim.loop

local _, pid = uv.spawn("bash", {
    args = {
        "-c",
        "while true; do echo \"1\"; sleep 1; done"
    }
})

uv.kill(pid, "SIGTERM")
vim.schedule(function()
    local ret = uv.kill(pid, "sigterm")
    if not ret then
        print(pid.." not found")
    else
        print(pid.." closed")
    end
end)

Configuration:

  • Neovim version (nvim --version):v0.9.4
  • Operating system and version:macOS

Checklist:

  • My code follows the style guidelines of this project (stylua)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (lua annotations)

@tex
Copy link

tex commented Nov 27, 2023

I can confirm this fixes the problem.

@Conni2461
Copy link
Member

LUL 😆 thanks :)

@Conni2461 Conni2461 merged commit 84c5a71 into nvim-telescope:master Nov 27, 2023
6 checks passed
Conni2461 pushed a commit that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AsyncJob close not working
3 participants