Fix resize/preview toggles of the cursor layout #2718
Conversation
|
Before: Screencast.from.2023-09-26.01-17-52.webmAfter: Screencast.from.2023-09-26.02-30-03.webm |
|
just wondering what picker is this? |
|
@max397574 It's a custom one I'm working on for my dotfiles. |
The cursor layout uses winline() and wincol() to calculate the cursor position. Both these functions operate on the currently active window. The first time the calculations are performed, that happens to be the window active before showing the Telescope window. However, if the editor is then resized or the preview window is toggled, the active window changes. The result is that recalculating the position is then done using the wrong window, resulting in the Telescope window moving around in an erratic manner. To fix this, we have to scope the winline() and wincol() calls to the original window ID.
|
It seems GitHub isn't updating the pull request for some reason, but either way the changes are indeed in my fork (https://github.com/yorickpeterse/telescope.nvim/commit/4ef39b23eb955cd49b6f129a12bc2ef3aaeddfe4). Perhaps GitHub is a bit slow with handling pushes at the moment... |
|
@jamestrew again please update commit message on merge, if they are not conventional commits already. |
Ahh sorry I misunderstood your original request. I thought you meant clear and sensible commit messages, not specifically conventional commits 😅 I'll make sure to follow the conventional commit format in my future PRs. Thoughts on adding a conventional commit linting ci? |
this doesnt help, because we squash the commits, and if a PR has multiple commits, it defaults to PR title, which again can be none conventional and then it hits master which is already too late. if you scroll though the commit history you notice that the current system works good enough. Once a new person with commit rights comes in, some slip through but after a quick reminder its goes back to mostly conventional.
Your PRs were fine, it was some PRs you merge. On "rebase and merge" you then can edit the message to be conventional.
no harm done :D maybe i explained it wrong, currently cant recall 😆 |
The cursor layout uses winline() and wincol() to calculate the cursor position. Both these functions operate on the currently active window. The first time the calculations are performed, that happens to be the window active before showing the Telescope window. However, if the editor is then resized or the preview window is toggled, the active window changes. The result is that recalculating the position is then done using the wrong window, resulting in the Telescope window moving around in an erratic manner. To fix this, we have to scope the winline() and wincol() calls to the original window ID.
The cursor layout uses winline() and wincol() to calculate the cursor position. Both these functions operate on the currently active window. The first time the calculations are performed, that happens to be the window active before showing the Telescope window. However, if the editor is then resized or the preview window is toggled, the active window changes. The result is that recalculating the position is then done using the wrong window, resulting in the Telescope window moving around in an erratic manner. To fix this, we have to scope the winline() and wincol() calls to the original window ID. (cherry picked from commit 5c91b85)
The cursor layout uses winline() and wincol() to calculate the cursor position. Both these functions operate on the currently active window. The first time the calculations are performed, that happens to be the window active before showing the Telescope window. However, if the editor is then resized or the preview window is toggled, the active window changes. The result is that recalculating the position is then done using the wrong window, resulting in the Telescope window moving around in an erratic manner. To fix this, we have to scope the winline() and wincol() calls to the original window ID.
Description
The cursor layout uses winline() and wincol() to calculate the cursor position. Both these functions operate on the currently active window. The first time the calculations are performed, that happens to be the window active before showing the Telescope window. However, if the editor is then resized or the preview window is toggled, the active window changes. The result is that recalculating the position is then done using the wrong window, resulting in the Telescope window moving around in an erratic manner.
To fix this, we have to scope the winline() and wincol() calls to the original window ID.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
To test, you'll need to use the
cursorlayout. If you then show Telescope, followed by either resizing the editor window or toggling the preview panel on/off, you'll notice the Telescope window moving around in an erratic manner. This is no longer the case with these changes.Configuration:
Checklist: