fix: opening file starting with a plus #2509
Conversation
lua/telescope/actions/set.lua
Outdated
| @@ -165,6 +165,9 @@ action_set.edit = function(prompt_bufnr, command) | |||
| -- prevents restarting lsp server | |||
| if vim.api.nvim_buf_get_name(0) ~= filename or command ~= "edit" then | |||
| filename = Path:new(vim.fn.fnameescape(filename)):normalize(vim.loop.cwd()) | |||
| if filename:sub(1, 1) == "+" then | |||
| filename = "\\" .. filename | |||
| end | |||
There was a problem hiding this comment.
Can't we put the vim.fn.fnameescape after the Path:new?
filename = Path:new(filename):normalize(vim.loop.cwd())
filename = vim.fn.fnameescape(filename)
pcall(vim.cmd, string.format("%s %s", command, filename))I think this might be more robust
There was a problem hiding this comment.
i am pretty sure we already had this and i broke things (like this was early telescope), but we could try again.
There was a problem hiding this comment.
I'm not sure if vim.fn.fnameescape inside the Path:new is serving much purpose.
edit: just missed your reply before posting this - this wasn't meant as a response to your reply
There was a problem hiding this comment.
so fnameescape breaks $types.d.ts in cwd e.g.
I dont know what the inner fnameescape does ^^
There was a problem hiding this comment.
so fnameescape breaks $types.d.ts in cwd e.g.
really? I'm not experiencing this
touch "$types.d.ts" followed by
:lua vim.cmd(string.format("e %s", vim.fn.fnameescape("$types.d.ts")))
There was a problem hiding this comment.
seems like the issue is that we do the fnameescape twice, once outside and once inside Path, thats why it wasnt working, when i just tested it
963b31d
to
16e7252
Compare
|
lets try it, but i am not gonna backport it yet, gonna wait one day |
|
I can't seem to reproduce any errors/files that dont seem to open correctly. Thanks for the help :) |
(cherry picked from commit ebf9339)
fix #2502