Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(action): grep_string select_default with nil column #2447

Merged

Conversation

jamestrew
Copy link
Contributor

Description

Regression bug from #2416 where grep_string results without column numbers where not respecting the row number on select_default when using grep_string with the command :Telescope grep_string search=<CR>

Closes #2444

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list relevant details about your configuration

  • Verify bug fix
  • use :Telescope grep_string search=<CR> to grep for anything that's not that on the first line of the file
  • select_default on some entry - the file should open on the correct line
  • also verify regular :Telescop grep_string<CR> works as expected taking you to the correct row/col of the file
  • open a buffer and move the cursor to somewhere not [1,1]
  • open a new split :vnew
  • :Telescope buffers and open the buffer from above -> cursor should be in the same location between the two windows
  • open a new split :vnew
  • :Telescope find_files and open the file from above -> cursor should be in the same location between the windows (previously would always go to [1,1])

Configuration:

  • Neovim version (nvim --version): NVIM v0.9.0-dev-1290+g2257ade3d
  • Operating system and version: Linux archlinux 6.1.12-arch1-1

Checklist:

  • My code follows the style guidelines of this project (stylua)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (lua annotations)

@Conni2461
Copy link
Member

thanks :) i've rebased the branch because of duplicated docgen ^^

@Conni2461 Conni2461 merged commit 031322a into nvim-telescope:master Apr 9, 2023
Conni2461 pushed a commit that referenced this pull request Apr 9, 2023
@jamestrew jamestrew deleted the fix/action-edit-row-number branch April 9, 2023 19:49
abelmul pushed a commit to abelmul/telescope.nvim that referenced this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grep_string does not jump to correct line
2 participants