Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: proof-read edits #2311

Merged
merged 2 commits into from
Jan 22, 2023
Merged

Conversation

jamestrew
Copy link
Contributor

Description

Proof-read edits of the help docs. Mostly related to spelling/grammar errors, minor formatting clean ups and other nitpicks.

Type of change

  • This change requires a documentation update

How Has This Been Tested?

Read through of the docs - still wip

Configuration:

  • Neovim version (nvim --version): NVIM v0.9.0-dev-590+g6ba34e21f
  • Operating system and version: Linux archlinux 6.1.2-arch1-1

Checklist:

  • My code follows the style guidelines of this project (stylua)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (lua annotations)

@jamestrew jamestrew force-pushed the docs/proof-read branch 2 times, most recently from 97f577d to 412ed46 Compare January 14, 2023 00:48
@jamestrew
Copy link
Contributor Author

@Conni2461 @fdschmidt93 sorry guys, it looks like the docgen action is failing for me:

Run # We have to build the parser every single time to keep up with parser changes
fatal: reference is not a tree: 86f74dfb69c570f0749b241f8f5489f8f50adbea
Error: Process completed with exit code 128.

Can't really review my changes without it.

On a related note, with help docs tree-sitter being a thing, it would be possible to have syntax highlighting for lua code blocks provided the docgen code supports it. I'd offer to go through the docs again to add the lua tags.

@Conni2461
Copy link
Member

thanks for pining, docgen ci should be fixed on master.

On a related note, with help docs tree-sitter being a thing, it would be possible to have syntax highlighting for lua code blocks provided the docgen code supports it. I'd offer to go through the docs again to add the lua tags.

Didn't know about that. i try to add support but first i need to check why tree-sitter lua master isnt working as expected. Thats why we are checking out 86f74dfb69c570f0749b241f8f5489f8f50adbea

@jamestrew jamestrew marked this pull request as ready for review January 15, 2023 20:58
@Conni2461
Copy link
Member

LGTM thanks :)

I've made a todo for syntax highlighting and try to work on it soonish

@Conni2461 Conni2461 merged commit 053f230 into nvim-telescope:master Jan 22, 2023
Conni2461 pushed a commit that referenced this pull request Jan 22, 2023
(cherry picked from commit 053f230)
@Conni2461 Conni2461 mentioned this pull request Feb 19, 2023
4 tasks
@jamestrew jamestrew deleted the docs/proof-read branch March 1, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants