fix(old_files): opts.cwd_only includes similarly named dirs #2308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwd_only would also include unrelated folders, provided the current folder name was a prefix. Add a trailing / to the folder name to be sure to limit to this folder only. Example: current folder is /home/user/fold. Telescope would also offer files from /home/user/folder.
bd94c79
to
971e4d7
Compare
kkharji
approved these changes
Jan 7, 2023
There was a problem hiding this comment.
Great catch @emmanueltouzery indeed it does include similar named directories. This PR indeed fixes it.
Thanks
4 tasks
Conni2461
pushed a commit
to emmanueltouzery/telescope.nvim
that referenced
this pull request
Jan 7, 2023
…escope#2308) (cherry picked from commit 04af51d)
Conni2461
pushed a commit
that referenced
this pull request
Jan 7, 2023
(cherry picked from commit 04af51d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cwd_only would also include unrelated folders, provided the current folder name was a prefix
Example: current folder is /home/user/fold. Telescope would also offer files from /home/user/folder.
Type of change
How Has This Been Tested?
Create one folder named fold, another one named folder. Open and save fold/file1.txt and folder/file2.txt. Then run ":cd fold", and invoke
lua require'telescope.builtin'.oldfiles{cwd_only=true}.Without the fix, telescope will offer you both file1.txt and file2.txt. With the fix, telescope will offer you only file1.txt.
Configuration:
Checklist:
PS: could it be possible to also backport this fix to the 0.1 stable branch?