Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error due to concatenating table to string #2108

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Fix error due to concatenating table to string #2108

merged 1 commit into from
Aug 1, 2022

Conversation

christoph-blessing
Copy link
Contributor

Description

This pr fixes a bug that lead to an error because we tried to
concatenate a table (err) to a string. Now we concatenate
err.message (a string) to the string.

Fixes #2098

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Due to the simplicity of the change I only did a manual test.

Configuration:

  • Neovim version (nvim --version):
NVIM v0.8.0-dev-699-gcbfae548e8
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3
Compilation: /usr/bin/cc -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions     -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security     -fstack-clash-protection -fcf-protection -Wp,-U_FORTIFY_SOURCE -Wp,-D_FORTIFY_SOURCE=1 -DNVIM_TS_HAS_SET_MATCH_LIMIT -DNVIM_TS_HAS_SET_ALLOCATOR -O2 -g -Og -g -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wdouble-promotion -Wmissing-noreturn -Wmissing-format-attribute -Wmissing-prototypes -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fno-common -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -DMIN_LOG_LEVEL=3 -I/home/chris/pkgs/neovim-git/src/build/cmake.config -I/home/chris/pkgs/neovim-git/src/neovim-git/src -I/usr/include -I/home/chris/pkgs/neovim-git/src/build/src/nvim/auto -I/home/chris/pkgs/neovim-git/src/build/include
Compiled by chris@archie-work

Features: +acl +iconv +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/share/nvim"

Run :checkhealth for more info
  • Operating system and version:
Linux archie-work 5.18.14-arch1-1 #1 SMP PREEMPT_DYNAMIC Sat, 23 Jul 2022 11:46:17 +0000 x86_64 GNU/Linux

Checklist:

  • My code follows the style guidelines of this project (stylua)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (lua annotations)

@christoph-blessing
Fix error due to concatenating table to string
2ea5485 
This commit fixes a bug that lead to an error because we tried to
concatenate a table (`err`) to a string. Now we concatenate
`err.message` (a string) to the string.
Conni2461
Conni2461 approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@Conni2461 Conni2461 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks :)

@Conni2461 Conni2461 merged commit 2e05e63 into nvim-telescope:master Aug 1, 2022
Conni2461 pushed a commit that referenced this pull request Aug 1, 2022
@christoph-blessing @Conni2461
fix: error due to concatenating table to string (#2108)
7a84733 
This commit fixes a bug that lead to an error because we tried to
concatenate a table (`err`) to a string. Now we concatenate
`err.message` (a string) to the string.

(cherry picked from commit 2e05e63)
@christoph-blessing christoph-blessing deleted the fix_issue_2098 branch August 2, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conni2461 Conni2461 Conni2461 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error concatenating table to string
2 participants
@christoph-blessing @Conni2461