fix(resolve): Check val not nil in resolve funcs #2097
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We did not check
val ~= nil
in the resolve functions, so config like{ nil, max = 30 }
will throw a nil error. Also, if the config is{ padding = _ }
, the logic relies on the function handling the padding is iterated before the one handling min/max in the map, which is not always guaranteed.Fix the bug by adding nil check in the function handling min/max. Close
Fixes #2091
Type of change
Checklist: