-
-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make search progress more user friendly #1713
Comments
Dear @bercly0b, have you tried telescope-fzf-native? I'm away from my computer now but I'm almost sure it behaves the same as in the fzf gif. |
Hi @alefpereira |
@bercly0b I'm curious about that. I see you have a lot of patterns in your Try to remove those patterns from telescope and use a custom I use this command
|
@bercly0b please let me know if it worked. I'm almost sure the custom There is even this recipe that setup a function to use |
With But there is one interesting thing. |
I think it would be helpful to have an visual indicator while a search process is running in the background. Like FZF does with this animated circle of dots for example. This could also be displayed on right side of the prompt where the result count is shown. |
You're welcome @bercly0b, glad to help. I tested both telescope and the terminal For me it seems that telescope do the sorting in two different moments/stages, one as you type, and the other, showing a different sorting after a second or so, runs on background, or maybe debounced idk, while in I also tested both |
In @bercly0b, @hbiel I'm not a Telescope member but I like to contribute to projects I really like in my free time. But I'm not having much of that these days, If you guys could help, at least with some analysis or understanding how telescope handles this, we could work on that together. |
I feel the same, not having as much time myself. But i can try. :-) What i found so far regarding the progress indicator: The picker has an an status_updater which can be called to update the status text in the prompt. telescope.nvim/lua/telescope/pickers.lua Lines 1194 to 1223 in f262e7d
This updater uses the function get_status_text to determine which text to display: telescope.nvim/lua/telescope/config.lua Lines 363 to 390 in f262e7d
This even has some commented code which should display an indicator whether the search is completed or still running. Something seems to be missing here. |
@hbiel thanks you for links to code. And I think there are a couple more things that need to be discussed:
I think it would be great if someone from the telescope team will advise us |
We talked about adding search animations some time ago but the whole ui is currently bottle necking so its not on top of our priority list. The ui rewrite happens here #1491 |
Hi! Was looking into the same issue as using the raw fzf command feels more snappy than telescope on large code bases such as the UnrealEngine one. I need to do more thorough timing but the overall timing of a similar search seems close, but the fact that results starts showing up progressively makes it feel like actually fzf is quite faster. |
@jelmansouri telescope won't be as fast as raw fzf |
Hi guys.
I'm trying to switch from fzf to telescope and there is one thing that blocks me.
Is your feature request related to a problem? Please describe.
When I'm searching (find_files, live_grep), I don't understand the search is over and nothing is found or the search is in progress.
In gif, after a few seconds, the total number of files will change
telescope gif
Describe the solution you'd like
In fzf.vim search progress is more user friendly
fzf gif
Is it possible to make the same "live" progress in a telescope?
The text was updated successfully, but these errors were encountered: