Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native curl > plenary job curl #62

Closed
Conni2461 opened this issue Feb 5, 2021 · 4 comments
Closed

native curl > plenary job curl #62

Conni2461 opened this issue Feb 5, 2021 · 4 comments
Assignees

Comments

@Conni2461
Copy link
Collaborator

Thats more of a tracking issue. I kinda wanna do it but want some opinions first.

@tami5 Curl is great but we have way too many layers:

  • lua -> plenary job -> uv.spawn -> cli interface -> c -> profit

I was thinking maybe we could just rewrite it with native c bindings (ffi) which would give us something like this:

  • lua -> (ffi) -> c -> mega profit

Currently i am thinking having a curl, curl_job and curl_native module. We try to load native curl and if that isn't available then we fallback to curl_job. curl is basically the public interface which will handle the fallback.

So if someone says i only wanna support curl_native he can also just call that.

We can also do some curl_extension stuff that is not supported with curl_job. Like providing stuff for the curl_multi interface. See here section The multi Interface

@tjdevries "Overkill" for plenary to do something like this?

@Conni2461 Conni2461 self-assigned this Feb 5, 2021
@kkharji
Copy link
Contributor

kkharji commented Feb 5, 2021

curl, curl_job and curl_native module.

Makes sense

@Conni2461
Copy link
Collaborator Author

And if ppl still think ours is not enough they can still use https://github.com/Lua-cURL/Lua-cURLv3 with luarocks/packer

@tjdevries
Copy link
Member

@Conni2461 you're allowed to merge whatever you want here if you're having fun and it works. :)

Seems like a cool idea

@Conni2461 Conni2461 mentioned this issue Feb 6, 2021
13 tasks
@Conni2461
Copy link
Collaborator Author

Kinda unnecessary 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants