Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin register failed on windows #4693

Closed
hustcer opened this issue Mar 2, 2022 · 3 comments · Fixed by #4793
Closed

Plugin register failed on windows #4693

hustcer opened this issue Mar 2, 2022 · 3 comments · Fixed by #4793
Labels
🐛 bug Something isn't working
Milestone

Comments

@hustcer
Copy link
Contributor

hustcer commented Mar 2, 2022

Describe the bug

Plugin register failed on windows

How to reproduce

  1. Run register -e capnp "C:\Program Files\nu\bin\nu_plugin_extra_query.exe" will get output:
Error: nu::parser::file_not_found (https://docs.rs/nu-parser/0.59.0/nu-parser/enum.ParseError.html#variant.FileNotFound)

  × File not found
   ╭─[entry #23:1:1]
 1 │ register -e capnp "C:\Program Files\nu\bin\nu_plugin_extra_query.exe"
   ·                   ─────────────────────────┬─────────────────────────
   ·                                            ╰── File not found: "C:\Program Files\nu\bin\nu_plugin_extra_query.exe"
   ╰────
  1. Actually the plugin file exists:
    Run ls "C:\Program Files\nu\bin\nu_plugin_extra_query.exe" will get:
╭───┬───────────────────────────────────────────────────┬──────┬─────────┬──────────────╮
│ # │                       name                        │ type │  size   │   modified   │
├───┼───────────────────────────────────────────────────┼──────┼─────────┼──────────────┤
│ 0 │ C:\Program Files\nu\bin\nu_plugin_extra_query.exe │ file │ 1.6 MiB │ 19 hours ago │
╰───┴───────────────────────────────────────────────────┴──────┴─────────┴──────────────╯

Expected behavior

Plugin register should work on windows

Screenshots

No response

Configuration

key value
version 0.59.0
branch main
short_commit 42f1874
commit_hash 42f1874
commit_date 2022-03-01 13:05:29 +00:00
build_os windows-x86_64
rust_version rustc 1.59.0 (9d1b2106e 2022-02-23)
rust_channel stable-x86_64-pc-windows-msvc
cargo_version cargo 1.59.0 (49d8809dc 2022-02-10)
pkg_version 0.59.0
build_time 2022-03-01 13:52:36 +00:00
build_rust_channel release
features dataframe, default, trash, which, zip
installed_plugins

Additional context

No response

@hustcer
Copy link
Contributor Author

hustcer commented Mar 2, 2022

It seems to be caused by the quotes around C:\Program Files\nu\bin\nu_plugin_extra_query.exe, but there is a space in the path, how to do with it?

@sophiajt
Copy link
Contributor

sophiajt commented Mar 2, 2022

I think we should change the parser to be able to handle the quotes when doing register

@fdncred fdncred added the 🐛 bug Something isn't working label Mar 2, 2022
@fdncred
Copy link
Collaborator

fdncred commented Mar 2, 2022

@hustcer I think a work-around is to cd to that directory and register the plugins from there.

@hustcer hustcer added the 0.60 label Mar 4, 2022
@hustcer hustcer added this to the v0.60.0 milestone Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants