Script works well on macOS does not work on Windows due to the lines break by "|"

[hustcer]

Describe the bug

Hi,
The following script works well on my macOS, but not work on windows:

# Creates a table listing the branches of a git repository and the day of the last commit
def 'git age' [
  repo: path # The repo path to show git age
] {

  cd $repo;
  git branch |
    lines |
    str substring 2, |
    wrap name |
    insert last_commit {
      get name |
      each {
        git show $it --no-patch --format=%ai | str to-datetime
      }
    } |
    sort-by last_commit
}

git age path-to-git-repo;

The output on windows:

> nu .\git\age.nu
  develop
* master
  #        name
──────────────────────
  0   [table 0 rows]


error: no values to work with
   ┌─ shell:22:5
   │
22 │     sort-by last_commit
   │     ^^^^^^^ no values to work with

It seems to be caused by the splitting of lines by "|", after change it to:

# Creates a table listing the branches of a git repository and the day of the last commit
def 'git age' [
  repo: path # The repo path to show git age
] {

  cd $repo;
  git branch | lines | str substring 2, | wrap name | insert last_commit {
      get name | each {
        git show $it --no-patch --format=%ai | str to-datetime
      }
    } | sort-by last_commit
}

git age path-to-git-repo;

will make it work on windows.

How to reproduce

Described as the above.

Expected behavior

The script should work both on macOS and windows, with "|" at the end of line be supported for a better readability

Screenshots

No response

Configuration

key	value
version	0.37.0
short_commit	f9ae882
commit_hash	f9ae882
commit_date	2021-09-14 19:45:30 +00:00
build_os	windows-x86_64
rust_version	rustc 1.55.0 (c8dfcfe04 2021-09-06)
rust_channel	stable-x86_64-pc-windows-msvc (default)
cargo_version	cargo 1.55.0 (32da73ab1 2021-08-23)
pkg_version	0.37.0
build_time	2021-09-14 20:08:37 +00:00
build_rust_channel	release
features	clipboard-cli, ctrlc, dataframe, default, rustyline, term, trash, uuid, which, zip
installed_plugins	binaryview, chart bar, chart line, fetch, from bson, from sqlite, inc, match, post, ps, query json, s3, selector, start, sys, textview, to bson, to sqlite, tree, xpath

Additional context

Thanks

[hustcer]

Still has this issue on nu v0.59.0, we have to change the pipelines in one line to make it work:

def 'git age' [
  repo: path    # The repo path to show git age
] {

  $'(ansi p)(char nl)Last commit info of local branches: (ansi reset)(char nl)(char nl)'
  cd $repo
  let branches = (git branch | lines | str substring '2,' | wrap name)
  $branches | update remote { |it| if (has-ref $'origin/($it.name)') { '   √' } else { '' } } | update author { |it| git show $it.name -s --format='%an' } | update last-commit {|it| git show $it.name --no-patch --format=%ci | into datetime } | sort-by last-commit
}

[hustcer]

It's interesting that this way will make it work both on mac and Windows:

# Creates a table listing the branches of a git repository and the day of the last commit
def 'git age' [
  repo: path    # The repo path to show git age
] {

  $'(ansi p)(char nl)Last commit info of local branches: (ansi reset)(char nl)'
  cd $repo
  ( # Use `()` to wrap the pipes to make them work on windows
    git branch
      | lines
      | str substring '2,'
      | wrap name
      | update remote { |it| if (has-ref $'origin/($it.name)') { '   √' } else { '' } }
      | update author { |it| git show $it.name -s --format='%an' }
      | update last-commit {|it| git show $it.name --no-patch --format=%ci | into datetime }
      | sort-by last-commit
  )
}

@jntrnr Can you explain why? and is this a bug?

[sophiajt]

This is a good question for design of the parser. Currently, I think it's written so that pipeline has to be wrapped in () to go across multiple lines.

I was chatting with @kubouch a couple weeks ago, and he mentioned that he thought the first case should also work (I think? @kubouch can confirm)

I think we should be able to make the first case work if we want.

[sophiajt]

I just tried this on macOS, and, like you said it works okay:

echo "hello" |
str length

I'm going to boot up a Windows machine and see why it doesn't work. I think the intent is that it should work across platforms.

[hustcer]

echo "hello" |
str length

@jntrnr This simple case works on windows, Try this one:

def 'git age' [
  repo: path    # The repo path to show git age
] {

    $'(ansi p)(char nl)Last commit info of local branches: (ansi reset)(char nl)'
    cd $repo
    git branch
      | lines
      | str substring '2,'
      | wrap name
      | update author { |it| git show $it.name -s --format='%an' }
      | update last-commit {|it| git show $it.name --no-patch --format=%ci | into datetime }
      | sort-by last-commit
}

[kubouch]

Yeah, I think it should be more flexible. I'd also love to be able to line up the | at the beginning, it looks so much nicer than the trailing |s.

[hustcer]

I have just tried the latest main, It's perfect now.