Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std bench improvement proposal #873

Merged
merged 8 commits into from
Jun 8, 2024
Merged

std bench improvement proposal #873

merged 8 commits into from
Jun 8, 2024

Conversation

maxim-uvarov
Copy link
Contributor

  • removed usage of a new external command math significant-digits
  • rounded precision to 4th digit including (max relative error of 0.05%)
  • in --pretty I replaced abs stddev with relative coefficient of variation (CV)

@amtoine, would you please take a look into my new variant once again?
Maybe this time it will be good enough?

image

@maxim-uvarov maxim-uvarov marked this pull request as ready for review June 7, 2024 13:21
@fdncred
Copy link
Collaborator

fdncred commented Jun 7, 2024

very cool

Copy link
Member

@amtoine amtoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxim-uvarov, yeah it's fine 👌

you know, as long as the command doesn't get too complex and it's possible to get the raw timings to compute any statistics, i'm happy 😉

@fdncred fdncred merged commit 398cc82 into nushell:main Jun 8, 2024
1 check passed
@fdncred
Copy link
Collaborator

fdncred commented Jun 8, 2024

Thanks

@maxim-uvarov maxim-uvarov deleted the bench3 branch June 8, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants